Refactor the demo UI (reduce ~520KB of static assets to ~4KB) #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove all JS dependencies (jQuery, CodeMirror etc) - Remove redundant stylesheets other assets. This PR gets rid of 520+ KB of dependencies and static assets that were used to render the simple demo typing page with a new page and a new autocomplete JS lib that total to <4 KB.
|
Thank you for cleaning things up :). Except for floattype everything can be merged. I'll modify the PR to use the already bundled embed script. Can't use floattype because:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was checking the lib that the demo UI uses to render suggestions that appear as you type (for Olam's transliteration page). Realised that it was using CodeMirror, a 65KB+ lib only for suggestions, which is unnecessary. Also noticed that there were a lot of other dependencies including jQuery and that the demo page assets amounted to 520+ KB.
I ended up writing a zero-dep lib (@knadh/floatype.js, ~1200 bytes) that renders floating suggestions as you type for Olam.
This PR gets rid of 520+ KB of dependencies and static assets that were used to render the simple demo typing page with a new page amounting to <4 KB.
Hope I didn't miss anything obvious here.